[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

Eugene Zemtsov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 6 11:06:01 PST 2018

eugene added inline comments.

Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:199
     case tok::greatergreater:
       template_counter -= 2;
       can_open_template = false;
labath wrote:
> While looking at the bug, this part here struck me as dubious.
> Can you check that this properly handles a name like `F<(3)>>(1)> f<3, 1>()` (which is the demangled form of _Z1fILi3ELi1EE1FIXrsT_T0_EEv).
oh my, you're right. this code doesn't account for shifts in the name. I'm going to submit this code anyway and then think about it.


More information about the lldb-commits mailing list