[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added a comment.

I see now Pavel has solved it by:

  [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers
  https://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180205/038992.html

I am not sure if that is not a more general solution but this patch should be faster/cheaper.
build-id's goal is to be at the very beginning of the file to fit into the Linux kernel `CORE_DUMP_DEFAULT_ELF_HEADERS` dumping of the first page (4096 bytes).  I see now some system files have the build-id at offset 0x274 for example so one would have to also change the 512 bytes chunk of `ObjectFile::GetModuleSpecifications:` to 4096 to make this patch really valid.


https://reviews.llvm.org/D42931