[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Can you fix the test case as mentioned inline.  If something doesn't work please just ping me and I'll fix it.  I'd like to get off propagating this boiler-plate...



================
Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestSymbolsSepDebugSymlink.py:23-37
+        exe = self.getBuildArtifact("dirsymlink/stripped.symlink")
+
+        self.target = self.dbg.CreateTarget(exe)
+        self.assertTrue(self.target, VALID_TARGET)
+
+        main_bp = self.target.BreakpointCreateByName("main", "stripped.symlink")
+        self.assertTrue(main_bp, VALID_BREAKPOINT)
----------------
You should be able to do all this with the run_to_name_breakpoint.  Pass "dirsymlink/stripped.symlink" as exe_name.  I just added the ability to limit the breakpoint to a particular module, so you can do that as well.

Having all this duplicated boiler-plate made Adrian's laudable job of building out of tree way more tedious than it should have been.  We should centralize this whenever possible.


https://reviews.llvm.org/D42853