[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 1 13:00:22 PST 2018

aprantl added inline comments.

Comment at: packages/Python/lldbsuite/test/api/listeners/TestListener.py:26
-        self.build()
labath wrote:
> I'm confused by these changes. I was under the impression that setUp() runs before each test method (and hence this should be NFC). Can you explain the reasoning behind this?
(see also my previous comment) 
`setUp` runs before everything else, but it runs once per testcase and `self.testMethodName` is not initialized yet. Therefore we can only run `self.build()` in `self.setUp()` in NO_DEBUG_INFO_TESTCASEs.


More information about the lldb-commits mailing list