[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

[Jim Ingham via lldb-commits]

Yeah, no reason to pile on this patch, mostly I was making sure I understood what we could do...

Jim


> On Feb 1, 2018, at 11:24 AM, Adrian Prantl via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> aprantl added a comment.
> 
> @jingham wrote:
> 
>> Now that we aren't mixing variants, would it be possible to have a test class claim that all the tests use the same binary file?  At present to get self-contained tests you often need to do roughly the same thing many times, on the same binary.  You only need to build it once per variant in that case.  Of course, not all tests would behave this way, some play tricks with the binary products mid-test.  But I bet the majority of test classes with more than one test method just build exactly the same thing as all the other tests, and don't modify it.
> 
> Yes, but I would like to keep this for a separate patch, since it is nontrivial:
> 
> - For NO_DEBUG_INFO_TESTCASEs this is as easy as invoking buildDefault() in self.setUp().
> - For tests with variants, we first would need to define a method setUpVariant() that behaves like setUp() in that is invoked for each variant but before any tests are executed.
> 
> 
> https://reviews.llvm.org/D42763
> 
> 
>