[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 1 03:36:54 PST 2018

labath added inline comments.

Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py:335-337
+            # However, if we aren't expecting an ack, it's likely the initial
+            # ack that lldb client sends, and observations of real servers
+            # suggest we're supposed to ack back.
Which servers were you observing here? I tried lldb-server and gdbserver and they don't send the ack back (It seems like a bad idea anyway, as it could lead to an infinite ack ping-pong).

I have removed this code as it was causing flakyness on the bots. If there is a server that does this, and we care about supporting it, then we can add a new targeted test which emulates this behavior, but then we need to also fix the client to handle this situation better.



More information about the lldb-commits mailing list