[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions
Owen Shaw via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jan 31 13:39:04 PST 2018
owenpshaw updated this revision to Diff 132260.
owenpshaw added a comment.
- Remove Begin/End memory batch API
- Add Process::WriteObjectFile(llvm::ArrayRef<WriteEntry>) method. Open to other names since it's not necessarily specific to object files, but wanted to somehow indicate that the method may do an uncommon write (like write to flash).
- Kept vFlashWrite as part of DoWriteMemory, and changed the is_batch_write flag to an allow_flash_writes flag. ProcessGDB:: WriteObjectFile sets allow_flash_writes, and then calls the regular WriteMemory. Didn't seem like there was a need to duplicate the WriteMemory logic.
- Any other memory write attempts to flash regions will now fail
I think this gets us closer to what we're talking about, but let me know if anything should change.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 30416 bytes
Desc: not available
More information about the lldb-commits