[Lldb-commits] [lldb] r323832 - [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf

[Davide Italiano via lldb-commits]

I went ahead for now and reverted in the hope this makes the bot green (again).

Committing to https://llvm.org/svn/llvm-project/lldb/trunk ...
commit f5d7ce2552c2003379bdbe78737f12dd50832b0d
Author: Davide Italiano <ditaliano at apple.com>
Date:   Tue Jan 30 20:14:32 2018 -0800

    Revert "[lldb] Enable debugging of binaries with mixed
(splitted/regular) dwarf"

    It might have caused some instability on the bots.

 delete mode 100644
packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile
 delete mode 100644
packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py
 delete mode 100644
packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/a.c
 delete mode 100644
packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/b.c


If the bots stay red, you can recommit (or I'll recommit on your behalf).

Thanks,

--
Davide

On Tue, Jan 30, 2018 at 5:03 PM, Davide Italiano <dccitaliano at gmail.com> wrote:
> On Tue, Jan 30, 2018 at 3:45 PM, Alexander Shaposhnikov via
> lldb-commits <lldb-commits at lists.llvm.org> wrote:
>> Author: alexshap
>> Date: Tue Jan 30 15:45:20 2018
>> New Revision: 323832
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=323832&view=rev
>> Log:
>> [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf
>>
>> Initialize the default value of SymbolFileDWARF uuid with
>> the appropriately shifted DW_INVALID_OFFSET constant.
>> This change fixes the collision in the computation of DIE uid
>> (inside DIERef::GetUID) and incorrect CompileUnit lookup
>> (because of the misleading cu_offset value).
>>
>> Test plan: make check-lldb
>>
>
> This commit seems to have caused some failures on the bots.
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4605/
>
> Can you please take a look? (and revert in case you're not able to
> figure out what's going on)
>
> --
> Davide