[Lldb-commits] [lldb] r323789 - Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE

[Adrian Prantl via lldb-commits]

Author: adrian
Date: Tue Jan 30 09:02:42 2018
New Revision: 323789

URL: http://llvm.org/viewvc/llvm-project?rev=323789&view=rev
Log:
Enforce that tests building with buildDefault set NO_DEBUG_INFO_TESTCASE

and fix resulting errors. This is a prerequisite for building each
test variant in its own build directory.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py
    lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-diagnose/array/TestArray.py
    lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py?rev=323789&r1=323788&r2=323789&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/api/check_public_api_headers/TestPublicAPIHeaders.py Tue Jan 30 09:02:42 2018
@@ -16,6 +16,7 @@ from lldbsuite.test import lldbutil
 class SBDirCheckerCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
+    NO_DEBUG_INFO_TESTCASE = True
 
     def setUp(self):
         TestBase.setUp(self)

Modified: lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py?rev=323789&r1=323788&r2=323789&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py Tue Jan 30 09:02:42 2018
@@ -15,6 +15,8 @@ import subprocess
 
 class SBBreakpointCallbackCase(TestBase):
 
+    NO_DEBUG_INFO_TESTCASE = True
+   
     def setUp(self):
         TestBase.setUp(self)
         self.generateSource('driver.cpp')

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-diagnose/array/TestArray.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-diagnose/array/TestArray.py?rev=323789&r1=323788&r2=323789&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-diagnose/array/TestArray.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/frame-diagnose/array/TestArray.py Tue Jan 30 09:02:42 2018
@@ -14,10 +14,12 @@ from lldbsuite.test import lldbutil
 class TestArray(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
+    def setUp(self):
+        TestBase.setUp(self)
+
     @skipUnlessDarwin
     @skipIfDarwinEmbedded  # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64
     def test_array(self):
-        TestBase.setUp(self)
         self.build()
         exe = self.getBuildArtifact("a.out")
         self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)

Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=323789&r1=323788&r2=323789&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Tue Jan 30 09:02:42 2018
@@ -1497,6 +1497,8 @@ class Base(unittest2.TestCase):
             dictionary=None,
             clean=True):
         """Platform specific way to build the default binaries."""
+        if self.debug_info:
+            raise Exception("buildDefault tests must set NO_DEBUG_INFO_TESTCASE")
         module = builder_module()
         dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
         if not module.buildDefault(