[Lldb-commits] [PATCH] D42563: [lldb] attempt to fix DIERef::GetUID

Tamas Berghammer via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 30 05:46:43 PST 2018

tberghammer accepted this revision.
tberghammer added a comment.

Thank you for looking into this. The change looks good on Linux with both normal-dwarf, split-dwarf and mixed-dwarf (as well as with dwp) but can you (or somebody from Apple) please make sure it doesn't break MachO and/or dSym (I don't expect any issue but I know little about that implementation)?

Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:4
+C_SOURCES := a.c b.c
I think these flags are specified by default in Makefile.rules

Comment at: packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/Makefile:10-12
+.PHONY: clean
+	$(RM) -f a.dwo a.o b.o main
Do you need this? I think Makefile.rules should generate it for you and looking at that rule it should be correct.



More information about the lldb-commits mailing list