[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 29 16:33:49 PST 2018

jingham added a comment.

Yes.  We do need to have symbols to do symbol completion, which does require a binary, but you don't need to run it.  Most of the other tests in there (e.g. simple command completion) should be able to work without even a binary.  It seems weird to add a potentially fallible lldb-test layer on top of SBCommandInterpreter.HandleCompletion just so you can send text input through lldb-test rather than directly sending text input to SBCommandInterpreter.HandleCommand.


More information about the lldb-commits mailing list