[Lldb-commits] [PATCH] D42656: [testsuite] Remove flakey test relying on `pexpect`

Davide Italiano via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 29 15:29:48 PST 2018

davide added a comment.

In https://reviews.llvm.org/D42656#991284, @zturner wrote:

> If we just need to test completion, write a lit-style test that uses lldb-test that looks like this:
>   RUN: lldb-test complete --target=%T/foo --complete_str=MyPrefix | FileCheck %s
>   CHECK: Foo::Bar
>   CHECK: Foo::Baz
>   etc
> Simple and not flaky

That sound a great idea. I'll work on something like that in case this turns out to be unreliable (or, independently, when I get a chance :)

In the meanwhile, I reenabled the tests on https://reviews.llvm.org/rL323707 to see whether they fail on the bot.
FWIW, I agree that's a sledgehammer spinning an instance to test autocompletion.





More information about the lldb-commits mailing list