[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

[Tatyana Krasnukha via lldb-commits]

Like this idea of using breakpoint resolver very much. It's exactly how I see debugger's proper work in such cases.

> -----Original Message-----
> From: jingham at apple.com [mailto:jingham at apple.com]
> Sent: Tuesday, 23 January, 2018 8:43 PM
> To: reviews+D39967+public+2d921c2f326fdc8b at reviews.llvm.org; Tatyana
> Krasnukha via Phabricator <reviews at reviews.llvm.org>
> Cc: Tatyana.Krasnukha at synopsys.com; clayborg at gmail.com; lldb-
> commits at lists.llvm.org
> Subject: Re: [Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite
> function
> 
> It seems to me better to remove breakpoint sites under any memory that
> you are going to overwrite.  The old breakpoints aren't guaranteed to make
> any sense and, for instance, on x86 could do harm (they could end up in the
> middle of an instruction in the new TEXT.)
> 
> If you want to do this regularly, you should remove the breakpoints and then
> ask the breakpoint resolver to re-check the new code once it has been
> written.  If for instance you are writing down memory that you have debug
> info for, then it will reset the breakpoints based on the new symbols for this
> location.
> 
> Jim
> 
> 
> > On Jan 23, 2018, at 8:42 AM, Tatyana Krasnukha via Phabricator via lldb-
> commits <lldb-commits at lists.llvm.org> wrote:
> >
> > tatyana-krasnukha added a comment.
> >
> > Cannot promise that I'll do it (with all tests) quickly, but I'll do.
> >
> > One more question: what are the cases when intersection can happen,
> beside user forgot to disable it manually? (Will not it be annoying for user to
> get breakpoints in unpredictable locations after such situation?)
> >
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__reviews.llvm.org_D39967&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r
> =8NZfjV_ZLY_S7gZyQMq8mj7tiN4vlymPiSt0Wl0jegw&m=p7fMc9pHWz1TqLP
> GI2BcPpRTt7ir_dS_RN3DYanOVVw&s=ddJGG8U73bqnME4GDlY-N71n-
> aBo1zmXPw8KElfI19A&e=
> >
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-
> 2Dbin_mailman_listinfo_lldb-
> 2Dcommits&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=8NZfjV_ZLY_S7gZy
> QMq8mj7tiN4vlymPiSt0Wl0jegw&m=p7fMc9pHWz1TqLPGI2BcPpRTt7ir_dS_
> RN3DYanOVVw&s=nKin51JixOP9e1x0sEjcQyEKPKwP0j_iTt2LzdkMX-I&e=