[Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

Owen Shaw via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 22 09:58:26 PST 2018


owenpshaw updated this revision to Diff 130920.
owenpshaw added a comment.

Added back socket close()

It looks like the yaml2obj target hasn't been defined yet when the check-lldb target is defined, so if(TARGET yaml2obj) always returns false.  Is there another way to do the conditional dependency?  I'm assuming we don't want to reorder the includes in llvm/tools/CMakeLists.txt.


https://reviews.llvm.org/D42195

Files:
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/a.yaml
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
  test/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42195.130920.patch
Type: text/x-patch
Size: 18253 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180122/d93b9395/attachment-0001.bin>


More information about the lldb-commits mailing list