[Lldb-commits] [PATCH] D42182: Add LLDB_LOG_ERROR (?)

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: davide, zturner, jingham, clayborg.
Herald added a subscriber: emaste.

The difference between this and regular LLDB_LOG is that this one clears
the error object unconditionally.  This was inspired by the
ObjectFileELF bug (r322664), where the error object was being cleared
only if logging was enabled.

Of course, one could argue that since our logging is optional, it does
not really qualify as "handling" the error and we should leave it up to
the programmer to explicitly clear it if he really wants to.

It's not really clear to me which position is better. What do you think?


https://reviews.llvm.org/D42182

Files:
  include/lldb/Utility/Log.h
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  unittests/Utility/LogTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42182.130176.patch
Type: text/x-patch
Size: 4544 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180117/dfecae1e/attachment-0001.bin>