[Lldb-commits] [PATCH] D41962: Fix TestYMMRegisters for older machines without AVX2

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 12 08:18:13 PST 2018


jasonmolenda added a comment.

fwiw I'm working on upstreaming on zmm (avx512) patches that we have locally (there's one testsuite fail I still need to find time to fix) and the TestZMMRegister.py test that ChrisB wrote to test this is written as skip-unless-darwin, and there's a new skipUnlessFeature() method added to decorators.py which runs sysctl to detect hardware features (in this case, hw.optional.avx512f) which, I suspect, is an even more mac-specific way of doing this.  While Adrian's approach would be gcc/clang specific, it would def be better than depending on a sysctl.


Repository:
  rL LLVM

https://reviews.llvm.org/D41962





More information about the lldb-commits mailing list