[Lldb-commits] [PATCH] D41702: Add SysV Abi for PPC64le

[Alexandre Yukio Yamashita via Phabricator via lldb-commits]

alexandreyy added a comment.

I think the stack frame structure is not correct for the PPC64be plugin.
But it is hard to say how bad it is broken and fix the plugin without testing it.
The register numbers and stack frame structures are different from the ABI 1.9 to the ABI 2.0.

In https://reviews.llvm.org/D41702#971012, @labath wrote:

> In https://reviews.llvm.org/D41702#970887, @alexandreyy wrote:
>
> > Thanks, @labath .
> >  The ABI plugin for PPC64be is not working: https://reviews.llvm.org/D5988 .
> >  It was implemented based on the x86_64 plugin and needs to be fixed.
> >  We could commit this patch and merge the plugins when both plugins work properly.
>
>
> Hmm.. that complicates things a bit. How badly is it broken, do you estimate? Would it be any better than if we just made your new plugin handle the the big-endian target as well (just a best effort, I'm not asking you to actually test it on that target)?
>
> If the ppc64be FreeBSD target is really broken, and there is no desire to fix it, maybe we should just delete the relevant plugin.
>
> @emaste, @jhibbits: do you know what's the state of ppc64 lldb support in freebsd?





https://reviews.llvm.org/D41702