[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jan 7 11:58:01 PST 2018


mgorny updated this revision to Diff 128883.
mgorny retitled this revision from "[lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds" to "[lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB".
mgorny edited the summary of this revision.
mgorny added a comment.

Updated the patch to use LLVM_ENABLE_ZLIB directly.


https://reviews.llvm.org/D41725

Files:
  lit/CMakeLists.txt
  lit/lit.site.cfg.in


Index: lit/lit.site.cfg.in
===================================================================
--- lit/lit.site.cfg.in
+++ lit/lit.site.cfg.in
@@ -12,7 +12,7 @@
 config.python_executable = "@PYTHON_EXECUTABLE@"
 config.cc = "@LLDB_TEST_C_COMPILER@"
 config.cxx = "@LLDB_TEST_CXX_COMPILER@"
-config.have_zlib = @HAVE_LIBZ@
+config.have_zlib = @LLVM_ENABLE_ZLIB@
 
 # Support substitution of the tools and libs dirs with user parameters. This is
 # used when we can't determine the tool dir at configuration time.
Index: lit/CMakeLists.txt
===================================================================
--- lit/CMakeLists.txt
+++ lit/CMakeLists.txt
@@ -11,6 +11,10 @@
   set(ENABLE_SHARED 0)
 endif(BUILD_SHARED_LIBS)
 
+# the value is not canonicalized within LLVM
+llvm_canonicalize_cmake_booleans(
+  LLVM_ENABLE_ZLIB)
+
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in
   ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41725.128883.patch
Type: text/x-patch
Size: 944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180107/0cc1d70e/attachment.bin>


More information about the lldb-commits mailing list