[Lldb-commits] [PATCH] D41352: debugserver: Propagate environment in launch-mode (pr35671)

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D41352#958549, @clayborg wrote:

> We already have an option for this named "--forward-env". It might be better to fix this by adding the "--forward-env" argument to the debugserver launch during testing? When we launch through LLDB, it forwards all environment variables manually. Maybe we add a "--forward-env" option to lldb-server too? Not sure what the right thing to do here is. iOS, tvOS and watchOS won't be affected since we never launch directly and all env vars are manually set by LLDB. Jason, any comments on this one?


Ah, I haven't noticed that. I can definitely add the `--forward-env` to the test if you that's the behavior you want. However, I think that the default behavior of inheriting the environment for the "launch" mode makes more sense.


https://reviews.llvm.org/D41352