[Lldb-commits] [PATCH] D41359: Add Utility/Environment class for handling... environments

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 18 09:26:49 PST 2017

zturner added inline comments.

Comment at: include/lldb/Utility/Environment.h:70-72
+  std::pair<iterator, bool> insert(llvm::StringRef KeyEqValue) {
+    return insert(KeyEqValue.split('='));
+  }
Why'd you decide to go with inserting an entire pre-formatted key value pair in the form `{key}={value}`, instead of having the function be `insert(StringRef Key, StringRef Value)`?

Comment at: source/Host/macosx/Host.mm:763
-            proc_env.AppendArgument(llvm::StringRef(cstr));
+	    proc_env.insert(cstr);
Indentation is messed up here.


More information about the lldb-commits mailing list