[Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Sat Dec 2 12:26:36 PST 2017
I'm curious why it's not working as it's supposed to work on these
platforms. When it does work, it's quite helpful
On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano <dccitaliano at gmail.com>
> Maybe we should remove this feature altogether?
> On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
> > Author: jingham
> > Date: Fri Dec 1 16:11:18 2017
> > New Revision: 319598
> > URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev
> > Log:
> > Don't use llvm::EnablePrettyStackTrace on macOS.
> > LLDB.framework gets loaded into Xcode and other
> > frameworks, and this is inserting a signal handler into
> > the process even when lldb isn't used. I have a bunch
> > of reports of this SignalHandler blowing out the stack,
> > which renders crash reports for the crash useless.
> > And in any case libraries really shouldn't be installing
> > signal handlers.
> > I only turned this off for APPLE platforms, I'll let
> > the maintainers of other platforms decide what policy
> > they want to have w.r.t. this.
> > Modified:
> > lldb/trunk/source/Initialization/SystemInitializerCommon.cpp
> > Modified: lldb/trunk/source/Initialization/SystemInitializerCommon.cpp
> > URL:
> > --- lldb/trunk/source/Initialization/SystemInitializerCommon.cpp
> > +++ lldb/trunk/source/Initialization/SystemInitializerCommon.cpp Fri
> Dec 1 16:11:18 2017
> > @@ -69,7 +69,9 @@ void SystemInitializerCommon::Initialize
> > }
> > #endif
> > +#if not defined(__APPLE__)
> > llvm::EnablePrettyStackTrace();
> > +#endif
> > Log::Initialize();
> > HostInfo::Initialize();
> > static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits