[Lldb-commits] [lldb] r319597 - Fix warning in DynamicLoaderDarwinKernel.cpp, NFC

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Sat Dec 2 12:22:44 PST 2017


On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
> Author: vedantk
> Date: Fri Dec  1 15:53:01 2017
> New Revision: 319597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=319597&view=rev
> Log:
> Fix warning in DynamicLoaderDarwinKernel.cpp, NFC
>
> Modified:
>     lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
>
> Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp?rev=319597&r1=319596&r2=319597&view=diff
> ==============================================================================
> --- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (original)
> +++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp Fri Dec  1 15:53:01 2017
> @@ -1407,7 +1407,7 @@ bool DynamicLoaderDarwinKernel::ReadAllK
>  void DynamicLoaderDarwinKernel::KextImageInfo::PutToLog(Log *log) const {
>    if (log == NULL)
>      return;
> -  const uint8_t *u = (uint8_t *)m_uuid.GetBytes();
> +  const uint8_t *u = (const uint8_t *)m_uuid.GetBytes();
>

Nit: I'd rather use static_cast<> :)

>    if (m_load_address == LLDB_INVALID_ADDRESS) {
>      if (u) {
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


More information about the lldb-commits mailing list