[Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

[Jim Ingham via lldb-commits]

If somebody finds themselves ambitious to work on debugserver, they should divert that energy to porting lldb-server to macOS IMHO.

Jim


> On Dec 1, 2017, at 4:04 PM, Jim Ingham <jingham at apple.com> wrote:
> 
> Yes, we don't use llvm code in debugserver.  It doesn't actually use any lldb classes either, it's its own standalone thing.
> 
> Jim
> 
> 
>> On Dec 1, 2017, at 4:01 PM, Zachary Turner via lldb-commits <lldb-commits at lists.llvm.org> wrote:
>> 
>> I don't recall, is there a hard restriction on debugserver not being allowed to use llvm code?  Because YAML is a superset of JSON
>> 
>> On Fri, Dec 1, 2017 at 3:36 PM Davide Italiano via lldb-commits <lldb-commits at lists.llvm.org> wrote:
>> Also, FWIW, this is blatantly not the correct way of using assertions.
>> It should either be assert(false && "patatino") or the more canonical
>> llvm_unreachable("patatino").
>> Relying on the implicit conversion from string to bool seems risky
>> (and not really useful).
>> 
>> On Fri, Dec 1, 2017 at 3:29 PM, Vedant Kumar via lldb-commits
>> <lldb-commits at lists.llvm.org> wrote:
>>> Author: vedantk
>>> Date: Fri Dec  1 15:29:04 2017
>>> New Revision: 319596
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=319596&view=rev
>>> Log:
>>> Fix warnings in JSON.cpp, NFC
>>> 
>>> These asserts are no-ops, and are supplanted by -Wcovered-switch.
>>> 
>>> Modified:
>>>    lldb/trunk/tools/debugserver/source/JSON.cpp
>>> 
>>> Modified: lldb/trunk/tools/debugserver/source/JSON.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/JSON.cpp?rev=319596&r1=319595&r2=319596&view=diff
>>> ==============================================================================
>>> --- lldb/trunk/tools/debugserver/source/JSON.cpp (original)
>>> +++ lldb/trunk/tools/debugserver/source/JSON.cpp Fri Dec  1 15:29:04 2017
>>> @@ -58,7 +58,6 @@ uint64_t JSONNumber::GetAsUnsigned() con
>>>   case DataType::Double:
>>>     return (uint64_t)m_data.m_double;
>>>   }
>>> -  assert("Unhandled data type");
>>> }
>>> 
>>> int64_t JSONNumber::GetAsSigned() const {
>>> @@ -70,7 +69,6 @@ int64_t JSONNumber::GetAsSigned() const
>>>   case DataType::Double:
>>>     return (int64_t)m_data.m_double;
>>>   }
>>> -  assert("Unhandled data type");
>>> }
>>> 
>>> double JSONNumber::GetAsDouble() const {
>>> @@ -82,7 +80,6 @@ double JSONNumber::GetAsDouble() const {
>>>   case DataType::Double:
>>>     return m_data.m_double;
>>>   }
>>> -  assert("Unhandled data type");
>>> }
>>> 
>>> void JSONNumber::Write(std::ostream &s) {
>>> 
>>> 
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>