[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 1 07:10:36 PST 2017
zturner added inline comments.
Comment at: lit/Modules/compressed-sections.yaml:1
+# REQUIRES: zlib
+# RUN: yaml2obj %s > %t
> zturner wrote:
> > labath wrote:
> > > It's right here. (I'm open to suggestions where to place it).
> > I see. I think part of the reason I didn't notice it is because it has a `.yaml` extension just like the old one, so I didn't notice this was really a test.
> > LLVM is a little inconsistent here (it has tests that end in `.ll` and `.s`, but not for most other file extensions), so can you rename this to `compressed-sections.test`?
> > At some point I think we should inject another directory in this hierarchy (i.e. `lit/test/Modules`), but since this is not going to be the first directory here, I guess it doesn't need to happen now.
> llvm (and lld) also have plenty of tests ending in .yaml. Since this is a yaml file, and plenty of editors have syntax highlighting for yaml, it seems a pitty not to take advantage of that.
I don't feel too strongly about this, but I do have a mild preference for having it end in `.test`. Another alternative to still get syntax highlighting is to have a `Inputs` folder and put the `.yaml` file there adn have the test file reference it. I'll defer to davide for a second opinion. If he's ok with the `.yaml` extension, I guess that's fine.
More information about the lldb-commits