[Lldb-commits] [PATCH] D40587: [lldb] Minor fixes in TaskPool
Francis Ricci via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 29 05:49:09 PST 2017
fjricci added inline comments.
Comment at: source/Host/common/TaskPool.cpp:55
+ static const unsigned g_hardware_concurrency =
+ std::max(1u, std::thread::hardware_concurrency());
+ return g_hardware_concurrency;
Is 1 the best default here when hardware_concurrency() isn't computable? Seems like it could have some big performance implications, and I'm not sure how common it is for people to debug on host machines that only support one thread.
More information about the lldb-commits