[Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()
Stephane Sezer via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 28 10:10:30 PST 2017
sas added a comment.
In https://reviews.llvm.org/D40537#937196, @zturner wrote:
> You could use llvm's range adapters to make this slightly better.
> auto Bytes = makeArrayRef(m_uuid, m_num_uuid_bytes);
> return llvm::find(Bytes, 0) != Bytes.end();
> Another option would just be `return *this != UUID(m_num_uuid_bytes);`
We want at least one **non-zero** element, we don't want a zero-element, so the proposed code wouldn't work. I'm not sure if there's an llvm utility that allows doing that directly without having to pass a lambda.
More information about the lldb-commits