[Lldb-commits] [PATCH] D40458: DWARFDebugInfoEntry: Remove unused: Contains, Clear, SetOffset

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Nov 25 09:17:16 PST 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL318981: Due to changes for DWZ I would need to update those such as renaming it to (authored by jankratochvil).

Changed prior to commit:
  https://reviews.llvm.org/D40458?vs=124261&id=124262#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D40458

Files:
  lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h


Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
===================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
@@ -1314,19 +1314,6 @@
   return false;
 }
 
-bool DWARFDebugInfoEntry::Contains(const DWARFDebugInfoEntry *die) const {
-  if (die) {
-    const dw_offset_t die_offset = die->GetOffset();
-    if (die_offset > GetOffset()) {
-      const DWARFDebugInfoEntry *sibling = GetSibling();
-      assert(sibling); // TODO: take this out
-      if (sibling)
-        return die_offset < sibling->GetOffset();
-    }
-  }
-  return false;
-}
-
 //----------------------------------------------------------------------
 // BuildAddressRangeTable
 //----------------------------------------------------------------------
Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
===================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
@@ -60,18 +60,6 @@
         m_empty_children(false), m_abbr_idx(0), m_has_children(false),
         m_tag(0) {}
 
-  void Clear() {
-    m_offset = DW_INVALID_OFFSET;
-    m_parent_idx = 0;
-    m_sibling_idx = 0;
-    m_empty_children = false;
-    m_abbr_idx = 0;
-    m_has_children = false;
-    m_tag = 0;
-  }
-
-  bool Contains(const DWARFDebugInfoEntry *die) const;
-
   void BuildAddressRangeTable(SymbolFileDWARF *dwarf2Data,
                               const DWARFCompileUnit *cu,
                               DWARFDebugAranges *debug_aranges) const;
@@ -211,8 +199,6 @@
 
   dw_offset_t GetOffset() const { return m_offset; }
 
-  void SetOffset(dw_offset_t offset) { m_offset = offset; }
-
   bool HasChildren() const { return m_has_children; }
 
   void SetHasChildren(bool b) { m_has_children = b; }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40458.124262.patch
Type: text/x-patch
Size: 1993 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171125/c2bee8f4/attachment.bin>


More information about the lldb-commits mailing list