[Lldb-commits] [PATCH] Use the DWARF linkage name when importing C++ methods

[Greg Clayton via lldb-commits]

Please submit a review of this patch through reviews.llvm.org <http://reviews.llvm.org/>. 

- svn diff -x -U99999 > /tmp/a.patch
- login or create a login if you don't already have one
- Select Differential from the top left corner
- Click "+ Create Diff" in upper right
- Click "Choose File" and select /tmp/a.patch, no need to fill anything in the Raw Diff field or Repository then click the "Create Diff" button
- Review your code and click the button to continue
- Fill in title, description and add the names of reviewers and add lldb-commits to the reviewers

> On Nov 19, 2017, at 10:33 PM, Nelson Elhage via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> When importing C++ methods into clang AST nodes from the DWARF symbol table, preserve the DW_AT_linkage_name and use it as the linker ("asm") name for the symbol.
> 
> Concretely, this enables `expression` to call into names that use the GNU `abi_tag` extension, and enables lldb to call into code using std::string or std::list from recent versions of libstdc++. See https://bugs.llvm.org/show_bug.cgi?id=35310 <https://bugs.llvm.org/show_bug.cgi?id=35310> . It also seems broadly more robust than relying on the DWARF->clang->codegen pipeline to roundtrip properly, but I'm not immediately aware of any other cases in which it makes a difference.
> 
> - Nelson
> <bug35310.diff>_______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171120/09b24e92/attachment-0001.html>