[Lldb-commits] [PATCH] D40212: refactor: Unify+simplify DWARFCompileUnit ctor+Clear() into in-class initializers

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Nov 19 02:09:00 PST 2017


labath added a comment.

You're using a fairly novel (to this codebase at least) simplification technique, so I think we should discuss that first. The way we have normally done these things is to just have the constructor call the Clear() function.

Personally, I am not really sure what to think about this approach. On one side, I kinda like it, but on the other one, it feels somewhat dodgy.


https://reviews.llvm.org/D40212





More information about the lldb-commits mailing list