[Lldb-commits] [PATCH] D39969: Set error status in ObjectFile::LoadInMemory if it is not set

Hafiz Abid Qadeer via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 15 02:59:42 PST 2017


abidh added inline comments.


================
Comment at: source/Symbol/ObjectFile.cpp:695
+              "One or more breakpoints intersect section '%s'",
+              section_sp->GetName().AsCString());
         return error;
----------------
If WriteMemory is not setting the error in some case, it seem more logical to properly handle it there instead of putting this specific error message here.


Repository:
  rL LLVM

https://reviews.llvm.org/D39969





More information about the lldb-commits mailing list