[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

Tatyana Krasnukha via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 14 22:45:31 PST 2017


tatyana-krasnukha updated this revision to Diff 122966.
tatyana-krasnukha added a comment.

Sorry for wrong formatting, I've removed it.

What I've actually done:

- grouped cases returning WriteMemoryPrivate in the top of function;
- moved last comment to code it relates;
- change other comment according what really will be returned in that case.

I hope that these changes improves readability and will help to avoid errors like I tried to fix in D39969 <https://reviews.llvm.org/D39969>


Repository:
  rL LLVM

https://reviews.llvm.org/D39967

Files:
  source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39967.122966.patch
Type: text/x-patch
Size: 5144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171115/15acabbd/attachment.bin>


More information about the lldb-commits mailing list