[Lldb-commits] [PATCH] D39967: Refactoring of MemoryWrite function

Tatyana Krasnukha via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 13 10:32:30 PST 2017


tatyana-krasnukha added inline comments.


================
Comment at: source/Target/Process.cpp:2462
-              // We weren't able to write all of the requested bytes, we
-              // are done looping and will return the number of bytes that
-              // we have written so far.
----------------
This comment says that function will return the number of written bytes, but really it will return zero in this case


================
Comment at: source/Target/Process.cpp:2484
 
   // Write any remaining bytes after the last breakpoint if we have any left
   return 0; // bytes_written;
----------------
This comment relates to line 2476 here


Repository:
  rL LLVM

https://reviews.llvm.org/D39967





More information about the lldb-commits mailing list