[Lldb-commits] [PATCH] D39896: Remove last Host usage from ArchSpec

Paul Robinson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 10 14:19:15 PST 2017


probinson added a comment.

Drive by comment:

In https://reviews.llvm.org/D39896#922224, @jingham wrote:

> You're right, the Triple stuff is in ADT!  I was using it as an example of something you clearly wouldn't do so I didn't actually check to see if it was done.  That's pretty funny.
>
> I thought that ADT stood for Abstract Data Types - though I actually I don't remember where I got that impression...  Having Triple there does seem confusing.  That is a "how we specify Targets type thing", not a fancy data type type thing...  I would never think to look for that facility alongside StringRef & DenseMap etc.


Triple.h is in ADT; Triple.cpp is in Support.  I agree it belongs in Support, and I'm not sure why it's schizo like that.


https://reviews.llvm.org/D39896





More information about the lldb-commits mailing list