[Lldb-commits] [PATCH] D39896: Remove last Host usage from ArchSpec

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 10 11:26:10 PST 2017


zturner added a comment.

I'd be open to having another organizational component that isn't Utility.  But as Jim said, there isn't a critical mass of stuff yet in Utility to figure out where it makes sense to draw the line.

In all honesty, that second component might just end up being "Core" again, if enough stuff can be moved out of Core that it doesn't have to depend on Symbol, Host, Interpreter, Breakpoint, etc.

BTW, I'm curious why you say that having Triple in llvm/ADT would be confusing.  Isn't that where it already is?  Or are you saying it's already confusing?

There's been some discussion on the LLVM side recently about how Support is just a catch-all for random stuff that doesn't really belong anywhere else, and there seems to be general support for separating some things out.  I actually made a small effort towards that end several months ago, when I took all of the object file format stuff out of Support and made a new target called BinaryFormat out of it.  But, it was easy to see what the best way to do that was because there was already a critical mass of stuff there, so it was easy to identify a logical grouping that could be separated.


https://reviews.llvm.org/D39896





More information about the lldb-commits mailing list