[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld

Stephane Sezer via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 6 09:30:53 PST 2017


Makes sense. I'll update the diff.

On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner <zturner at google.com> wrote:

> This is definitely required, but only on windows. I’d put it behind a
> check for Windows, and I’d also add a check to print a warning/error if
> (TARGET lld) returns false on windows
> On Mon, Nov 6, 2017 at 9:22 AM Davide Italiano via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> davide added a subscriber: zturner.
>> davide added a comment.
>>
>> Not sure lld is the default? I think I always build with bfd (or gold).
>> I'll check later today when I'm in the office. I'm not against this
>> change per se, but adding another dependency seems annoying. cc: @zturner
>>
>>
>> https://reviews.llvm.org/D39689
>>
>>
>>
>> --
-- 
Stephane Sezer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171106/5296d305/attachment.html>


More information about the lldb-commits mailing list