[Lldb-commits] [lldb] r317377 - Remove ProcessGdbRemote::m_flags

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 3 15:12:51 PDT 2017


Author: labath
Date: Fri Nov  3 15:12:50 2017
New Revision: 317377

URL: http://llvm.org/viewvc/llvm-project?rev=317377&view=rev
Log:
Remove ProcessGdbRemote::m_flags

The member is completely unused. Discussed on lldb-dev.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=317377&r1=317376&r2=317377&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Fri Nov  3 15:12:50 2017
@@ -244,7 +244,7 @@ bool ProcessGDBRemote::CanDebug(lldb::Ta
 //----------------------------------------------------------------------
 ProcessGDBRemote::ProcessGDBRemote(lldb::TargetSP target_sp,
                                    ListenerSP listener_sp)
-    : Process(target_sp, listener_sp), m_flags(0), m_gdb_comm(),
+    : Process(target_sp, listener_sp),
       m_debugserver_pid(LLDB_INVALID_PROCESS_ID), m_last_stop_packet_mutex(),
       m_register_info(),
       m_async_broadcaster(NULL, "lldb.process.gdb-remote.async-broadcaster"),
@@ -3255,7 +3255,6 @@ Status ProcessGDBRemote::DisableWatchpoi
 }
 
 void ProcessGDBRemote::Clear() {
-  m_flags = 0;
   m_thread_list_real.Clear();
   m_thread_list.Clear();
 }

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h?rev=317377&r1=317376&r2=317377&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h Fri Nov  3 15:12:50 2017
@@ -263,7 +263,6 @@ protected:
     eBroadcastBitAsyncThreadDidExit = (1 << 2)
   };
 
-  Flags m_flags; // Process specific flags (see eFlags enums)
   GDBRemoteCommunicationClient m_gdb_comm;
   std::atomic<lldb::pid_t> m_debugserver_pid;
   std::vector<StringExtractorGDBRemote> m_stop_packet_stack; // The stop packet
@@ -324,10 +323,6 @@ protected:
 
   void Clear();
 
-  Flags &GetFlags() { return m_flags; }
-
-  const Flags &GetFlags() const { return m_flags; }
-
   bool UpdateThreadList(ThreadList &old_thread_list,
                         ThreadList &new_thread_list) override;
 




More information about the lldb-commits mailing list