[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D38829#914305, @lawrence_danna wrote:

> @labath
>
> > Couldn't we just change the File::Read/Write functions to call these directly
>
> Like I said to @zturner , this is possible, but it can't work with the existing APIs in SBDebugger.h.


Ok, I am starting to understand what you want to do here.

> 
> 
>> And it would be great to see some tests for this
> 
> yup, there's tests in TestFileHandle.py

These may prove that you don't break existing functionality, but here you are introducing new one, which should be tested as well. (But don't go writing these yet until we figure out how exactly to implement this)


Repository:
  rL LLVM

https://reviews.llvm.org/D38829