[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 2 11:38:08 PDT 2017


clayborg added a comment.

Another option would be to add a URL version of these functions:

  class SBDebugger {
    void SetInputURL(const char *url);
    void SetOutputURL(const char *url);
    void SetErrorURL(const char *url);
  };

Then we allow this to trickle down to the IOBase in that way. This allows us to innovate by adding new support for new URLs.

"FILE*" is unfortunately what we will need for libedit for now, but we can probably make sure the IOBase call can provide this somehow, or convert a file descriptor into one, and fall back on a simple non-libedit based command interpreter if not. The current IOHandler stack will check the FILE's abilities and do the right thing already.


Repository:
  rL LLVM

https://reviews.llvm.org/D38829





More information about the lldb-commits mailing list