[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 1 17:35:00 PDT 2017


jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

IIUC, Zachary, Greg and I have all said we don't think adding regular expressions patterns to FileSpec is a good idea.  I'm not sure why you are pursuing this avenue.

Of course, if this were likely to get accepted, you'd have to add tests for it since this is totally new behavior.  But I almost don't want to bring that up since I don't want you to spend your time going off writing tests for a direction that we are unlikely to accept...


https://reviews.llvm.org/D39436





More information about the lldb-commits mailing list