[Lldb-commits] [lldb] r317130 - dotest: consistently call finalize_build_dictionary in debug info variants

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 1 15:01:03 PDT 2017


Author: labath
Date: Wed Nov  1 15:01:03 2017
New Revision: 317130

URL: http://llvm.org/viewvc/llvm-project?rev=317130&view=rev
Log:
dotest: consistently call finalize_build_dictionary in debug info variants

dwarf&dwo versions were doing it, but gmodules and dsym weren't. All
this function does right now is pass OS=Android to make when targeting
android. This enables us to run dotest without manually passing --env
OS=Android.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=317130&r1=317129&r2=317130&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Wed Nov  1 15:01:03 2017
@@ -1510,6 +1510,7 @@ class Base(unittest2.TestCase):
             clean=True):
         """Platform specific way to build binaries with dsym info."""
         module = builder_module()
+        dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
         if not module.buildDsym(
                 self,
                 architecture,
@@ -1560,6 +1561,7 @@ class Base(unittest2.TestCase):
             clean=True):
         """Platform specific way to build binaries with gmodules info."""
         module = builder_module()
+        dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
         if not module.buildGModules(
                 self,
                 architecture,




More information about the lldb-commits mailing list