[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

Hmm, weird.  Maybe it already is?  Even though I didn't see it on the original email.  Anyway, ignore my last suggestion.

On to actual comments: I'm not really crazy about the `regex:` prefix.  Seems ugly and non-intuitive.  Couldn't we just treat every filename as an argument to `fnmatch (3)`?  Then you don't need any weird prefixes.  Besides, `regex:foo` is a valid filename so if we're going to be making it so that some arguments to `-f` all of a sudden have to be escaped because they're no longer interpreted literally, then we might as well do it in a way that's intuitive and people are already familiar with.


https://reviews.llvm.org/D39436