[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: source/Core/ArchSpec.cpp:890
+bool ArchSpec::ContainsOnlyArch(const llvm::Triple &triple) {
+  return triple.getOSName().empty() &&
+         triple.getVendorName().empty() &&
----------------
Should you also add `!triple.getArchName().empty()` to the condition?  Also, perhaps name this parameter `normalized_triple` to document the expectation to the caller.


https://reviews.llvm.org/D39387