[Lldb-commits] [PATCH] D39315: Correct the start address for exported windows functions in arm

[Stephane Sezer via Phabricator via lldb-commits]

sas requested review of this revision.
sas added a comment.

I saw the `bool is_arm = ` pattern only in `ObjectFileMachO.cpp`. I'm not sure about the specifics for Darwin targets, but having an object file with some functions in ARM and some functions in Thumb is valid, so I think checking for each symbol is the right thing to do.

As for the `GetAddressClass` function, I have another diff that does exactly what you are talking about. I'll upload it when this one goes in.


https://reviews.llvm.org/D39315