[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 25 16:41:09 PDT 2017


$ nm /lib64/libm.so.6| grep " a$" 
0000000000093bb0 r a
00000000000c6a80 r a
0000000000093bb0 r a

No, they are internal to libm only.

Alex

On 10/25/17, 4:15 PM, "Greg Clayton" <clayborg at gmail.com> wrote:

    Not hard. Just find a test that has a shared library and copy it. Modify the shared library to create a symbol named "a". Then the main executable, just run the same lambda expression and it will fail on all platforms. The current fix in the review is just for internal symbols in other shared libraries, so don't make "a" public if you want it to pass. Did you say that "a" in libmath was public?
    
    Greg
    
    > On Oct 25, 2017, at 4:10 PM, Davide Italiano via Phabricator <reviews at reviews.llvm.org> wrote:
    > 
    > davide added a comment.
    > 
    > Thanks, I'll try this patch tomorrow.
    > I know this may be a little off, but how hard is to write a test for this so that it doesn't regress?
    > 
    > 
    > https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39307&d=DwIFAg&c=5VD0RTtNlTh3ycd41b3MUw&r=6r-mVtAxjRKWgeciEWgXiA&m=h9hoe4kEfRfn96OufBXdCIS_3py_y-MLJPBCpogA1To&s=ZxOsS7LJ5gkx_eYT2WwcoQs2g7pbaXOuzV1pTgBV_Mw&e=
    > 
    > 
    > 
    
    



More information about the lldb-commits mailing list