[Lldb-commits] [lldb] r316451 - Revert "[lldbtests] Handle errors instead of crashing."

[Pavel Labath via lldb-commits]

The breaking build is this one: <
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14775>

The blame email was sent (I know because I got it, as I also had a
commit in the same build). Is it possible you overlooked it?

```
def is_exe(fpath):
   if not os.path.exists(fpath):
       fpath = lit.util.which(fpath)
       if not (fpath and os.path.exists(fpath)):
         sys.exit(-1)
      return is_exe(fpath)

   return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
```
===

There is a which function in dotest.py -- the thing that made the fix
un-obvious is that it is implemented in terms of the is_exe function
:D.

So it will require a bit of refactoring to achieve this, which i did
not want to do in a hurry.



On 24 October 2017 at 09:10, Davide Italiano <dccitaliano at gmail.com> wrote:
> HI, I'm a little curious of what bot this breaks.
> FWIW, I don't think the bot should rely on this behaviour, and more
> importantly, I haven't received any failmail.
>
> Thanks,
>
> --
> Davide