[Lldb-commits] [PATCH] D39215: Default to using in-tree clang for building test executables

[Zachary Turner via lldb-commits]

Also worth noting is that the lit site config files only matter for 3-4
tests, which I don’t believe are run anywhere. I plan to overhaul this
whole system in the coming weeks/months, so personally I don’t mind much if
it breaks
On Mon, Oct 23, 2017 at 6:17 PM Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added a comment.
>
> In https://reviews.llvm.org/D39215#904578, @labath wrote:
>
> > I've played around with this, but I couldn't get the `lit/
> lit.site.cfg.in` file to see the expanded values of the
> `$<TARGET_FILE:clang>` generator expression (the reason it works now is
> because the file is special-casing LLDB_TEST_CLANG=True). Currently, I do
> not see how to work around that.
> >
> > So, I propose to separate the functional change from the cleanup, and
> leave the cleanup part to someone with more cmake-fu. :P
>
>
> I think we just need to do:
>
>   set(DEFAULT_LLDB_TEST_COMPILER "$<TARGET_FILE:clang>")
>
>   set(LLDB_TEST_COMPILER "${DEFAULT_LLDB_TEST_COMPILER}" CACHE PATH "Path
> to clang executable used to run LLDB tests")
>
> Does this not work?
>
>
> https://reviews.llvm.org/D39215
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171024/0a57e28b/attachment.html>