[Lldb-commits] [PATCH] D39199: [lldbtests] Handle errors instead of crashing

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: packages/Python/lldbsuite/test/dotest.py:52
 
 def is_exe(fpath):
+    """Returns true if fpath is an executable.
----------------
We could add a default parameter here like:

```
def is_exe(fpath, fatal=False):
  if fatal and not os.path.exists(fpath):
     ...
```

Then modify any callers. For the --compiler option we should verify it does exist and it should be fatal. Not sure how many other places use this.


https://reviews.llvm.org/D39199