[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

[Gustavo Serra Scalet via Phabricator via lldb-commits]

gut added inline comments.


================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:292
+    break;
+  case (eWatchpointKindRead + eWatchpointKindWrite):
+    rw_mode = PPC_BREAKPOINT_TRIGGER_RW;
----------------
As these enums are bitmasks, the traditional way of checking if more than one is set is to use the bitwise OR operator (`|`). Mostly because of the semantics, as you're not doing arithmetic there.


https://reviews.llvm.org/D38897