[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

[Leonard Mosescu via Phabricator via lldb-commits]

lemo updated this revision to Diff 117900.
lemo edited the summary of this revision.
lemo added a comment.

Updating the original changes to handle reentrant calls to CommandInterpreter::IOHandlerInputComplete().

- This fixes bug #34758
- Also enhanced the existing test case for "command source" to cover this regression
- I considered changing SBCommandReturnObject::PutOutput() to handle output interruptions too, but CommandReturnObjects are decoupled from CommandInterpreter instances, so there's no easy way to query for interruption in the current scheme.


https://reviews.llvm.org/D37923

Files:
  include/lldb/API/SBCommandInterpreter.h
  include/lldb/Core/IOHandler.h
  include/lldb/Interpreter/CommandInterpreter.h
  packages/Python/lldbsuite/test/functionalities/command_source/.lldb
  packages/Python/lldbsuite/test/functionalities/command_source/commands.txt
  scripts/interface/SBCommandInterpreter.i
  source/API/SBCommandInterpreter.cpp
  source/Commands/CommandObjectTarget.cpp
  source/Core/Debugger.cpp
  source/Interpreter/CommandInterpreter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37923.117900.patch
Type: text/x-patch
Size: 15943 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171005/08eac219/attachment.bin>