[Lldb-commits] [PATCH] D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type

[Leonard Mosescu via lldb-commits]

Identical, no - note the checks are inverted. Definitely uglier, but it's
defaulting to LLDB_CONFIGURATION_DEBUG if CMAKE_BUILD_TYPE is not defined,
right?

With the current defaulting rule I pointed out both versions should be
equivalent. If anything I prefer the 1st version since I like to avoid
negations in conditional expressions, but it's a minor thing and I'll leave
the final choice up to you.

On Wed, Oct 4, 2017 at 11:22 AM, Zachary Turner via Phabricator <
reviews at reviews.llvm.org> wrote:

> zturner added inline comments.
>
>
> ================
> Comment at: CMakeLists.txt:15
> +# Define the LLDB_CONFIGURATION_xxx matching the build type
> +if( NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" )
> +  add_definitions( -DLLDB_CONFIGURATION_RELEASE )
> ----------------
> Isn't this identical to the code before?
>
>
> https://reviews.llvm.org/D38552
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20171004/e565ef70/attachment.html>